Skip to content

Add reference types to TypeName #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 9, 2020
Merged

Add reference types to TypeName #444

merged 7 commits into from
May 9, 2020

Conversation

nathanwhit
Copy link
Member

Closes #438.

Just a couple of notes:

  • I'm not totally confident in the lowering
  • For parsing, I've made the assumption that references will always have an explicit lifetime specifier

@nathanwhit nathanwhit changed the title Add references to TypeName Add reference types to TypeName May 8, 2020
jackh726
jackh726 approved these changes May 9, 2020
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jackh726 jackh726 merged commit 582ea06 into rust-lang:master May 9, 2020
@jackh726
Copy link
Member

jackh726 commented May 9, 2020

@nathanwhit I think I merged this too early. &mut references shouldn't be copy/clone. Think you can do a followup PR?

@nathanwhit
Copy link
Member Author

@nathanwhit I think I merged this too early. &mut references shouldn't be copy/clone. Think you can do a followup PR?

Ah my bad, I overlooked that detail. I'll have a PR up in a few minutes.

@jackh726
Copy link
Member

jackh726 commented May 9, 2020

@nathanwhit I think I merged this too early. &mut references shouldn't be copy/clone. Think you can do a followup PR?

Ah my bad, I overlooked that detail. I'll have a PR up in a few minutes.

No problem, I didn't catch it either :) Thanks

@nathanwhit nathanwhit deleted the typename-refs branch May 25, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackh726 jackh726 jackh726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create TypeName for & and &mut
2 participants
@nathanwhit @jackh726