Remove --all-features
#15572
Open
Remove --all-features
#15572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `--all-features`, an option which does not exist in the current `cargo add`.
rustbot
added
A-documenting-cargo-itself
weihanglo
reviewed
May 21, 2025
| @@ -245,9 +245,6 @@ enabled: | |||
| `package-name/feature-name` syntax can be used to specify features for | |||
| specific workspace members. | |||
|
|
|||
| * `--all-features`: Activates all features of all packages selected on the | |||
There was a problem hiding this comment.
A simple removal is not the right fix here. cargo build and other commands do have that flag.
https://doc.rust-lang.org/nightly/cargo/commands/cargo-build.html#option-cargo-build---all-features
There was a problem hiding this comment.
Ah, I missed that, sorry. I'm happy to close this PR or continue to work on it based on any discussions on this or the referenced issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Fixes #15571
How should we test and review this PR?
N/A
Additional information
N/A