Skip to content

Add rollup mode management #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Add rollup mode management #221

merged 1 commit into from
Mar 11, 2025

Conversation

geetanshjuneja
Copy link
Contributor

Closes #208

Kobzol
Kobzol reviewed Mar 8, 2025
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR! Left a few comments. It would also be nice to have tests for the DB/command functionality.

@geetanshjuneja
Copy link
Contributor Author

what would be the behaviour if we set rollup mode before approving the PR?

@Kobzol
Copy link
Contributor

Kobzol commented Mar 9, 2025

Setting rollup mode and approving is independent. Setting the rollup mode just modifies the column in the DB, that's it :)

@geetanshjuneja geetanshjuneja requested a review from Kobzol March 9, 2025 10:41
Kobzol
Kobzol reviewed Mar 9, 2025
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! The conversion of the enum to a string should happen later, and the tests could use a bit of tweaking, but otherwise it looks to be pretty close to a working version.

@Kobzol Kobzol changed the title Added rollup parsing Add rollup mode management Mar 9, 2025
@geetanshjuneja geetanshjuneja requested a review from Kobzol March 9, 2025 16:35
Kobzol
Kobzol reviewed Mar 10, 2025
View reviewed changes
Kobzol
Kobzol reviewed Mar 10, 2025
View reviewed changes
Kobzol
Kobzol approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :) Please squash the commits now and we can merge it.

@geetanshjuneja geetanshjuneja requested a review from Kobzol March 11, 2025 08:49
Kobzol
Kobzol approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great work!

@Kobzol Kobzol added this pull request to the merge queue Mar 11, 2025
@Kobzol Kobzol mentioned this pull request Mar 11, 2025
Open
18 tasks
Merged via the queue into rust-lang:main with commit dd83a79 Mar 11, 2025
2 checks passed
@geetanshjuneja geetanshjuneja deleted the rollup branch March 23, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement rollup commands
2 participants
@geetanshjuneja @Kobzol