Remove unnecessary immediately invoked closures #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Karlsson <[email protected]>
petreeftime
approved these changes
Oct 7, 2022
| Ok(()) | ||
| }() | ||
| .unwrap_or_else(|e| panic!("test_read_line failed: {}", e)); | ||
| fn test_read_line() -> Result<(), Error> { |
There was a problem hiding this comment.
nit: These tests don't need to return anything.
|
bors r+ |
|
@matthiasbeyer I think bors is not enabled for this repo now. |
|
I requested it to be installed. 👍 May take a few. I will r+ this as soon as I get a notification that bors is installed. |
|
bors try |
tryBuild succeeded: |
|
bors merge |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the tests, they where likely added before tests could return Result.
For the code, likely got easier to handle with thiserror crate