-
Notifications
You must be signed in to change notification settings - Fork 286
Minor: fix missing import in doc example #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 7b7085f
I suspect that |
|
Thanks! That does seem to run the test. Though it actually passes without my change; I guess the test must import |
Oh |
Regarding the wasm failure, how come it broke now and not before? Looks like we're missing a pin somewhere but also the code needs to be fixed (possibly also in upstream). |
@Kixunil wasm has been broken for months and months. Lol @ "missing a pin". Good luck pinning anything in wasm. See my nearly-two-year-old "you can't pin anything" issue rustwasm/wasm-pack#1316 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 7b7085f; successfully ran local tests
@apoelstra clearly, this is some sort of compiler thing (though might be the |
Oh, it looks like |
Also, how do I get the doc-tests to actually test this example?