Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): add trademark footer note for homepage #5356

Merged
merged 2 commits into from
Feb 23, 2025

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Feb 23, 2025

@chenrui333 chenrui333 requested review from a team as code owners February 23, 2025 00:42
@chenrui333 chenrui333 requested review from jamengual, lukemassa and nitrocode and removed request for a team February 23, 2025 00:42
@dosubot dosubot bot added the website label Feb 23, 2025
jamengual
jamengual previously approved these changes Feb 23, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 23, 2025
@chenrui333
Copy link
Member Author

chenrui333 commented Feb 23, 2025

currently, it only shows the footer in the main homepage, but not on every page, gonna fix the layout a bit.

that might be a bug with vitepress, vuejs/vitepress#1037

@chenrui333
Copy link
Member Author

yeah, let's iterate on it (maybe finally need our custom layout)

@chenrui333 chenrui333 merged commit 58e3e99 into main Feb 23, 2025
33 checks passed
@chenrui333 chenrui333 deleted the trademarks-update branch February 23, 2025 01:02
@chenrui333 chenrui333 changed the title chore(website): add trademark footer note chore(website): add trademark footer note for homepage Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants