-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Adding Async Vector Memory #18676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adding Async Vector Memory #18676
Conversation
Looks like this is breaking tests (the code now assumes that timestamp is in the chat message dict, when it isn't) |
Fixed it to use a |
@logan-markewich Fixed all errors - need help looking @ 3.9, but doesn't seem apparent it was caused by changes I made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we actually recently added more async methods to the base index class
I might open a separate PR to handle the index-specific methods like _ainsert()
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
We are taking our forked llama index for basejump.ai and updating llama index with our changes to try to get back in sync. To test, I ran through our own test suite, which uses all of the changes. These changes are live in our production environment (minus some minor changes when resolving conflicts for the PR).
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lint
to appease the lint gods