Skip to content

Adding Async Vector Memory #18676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

amartinson193
Copy link
Contributor

@amartinson193 amartinson193 commented May 9, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Adding async capabilities to vector memory

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • N/A

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • N/A

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

We are taking our forked llama index for basejump.ai and updating llama index with our changes to try to get back in sync. To test, I ran through our own test suite, which uses all of the changes. These changes are live in our production environment (minus some minor changes when resolving conflicts for the PR).

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 9, 2025
@amartinson193 amartinson193 changed the title Adding async capabilities to vector memory Adding Async Vector Memory May 9, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 10, 2025
@logan-markewich
Copy link
Collaborator

Looks like this is breaking tests (the code now assumes that timestamp is in the chat message dict, when it isn't)

@logan-markewich logan-markewich self-assigned this May 13, 2025
@amartinson193
Copy link
Contributor Author

Looks like this is breaking tests (the code now assumes that timestamp is in the chat message dict, when it isn't)

Fixed it to use a .get() and a None instead

@amartinson193
Copy link
Contributor Author

@logan-markewich Fixed all errors - need help looking @ 3.9, but doesn't seem apparent it was caused by changes I made

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we actually recently added more async methods to the base index class

I might open a separate PR to handle the index-specific methods like _ainsert()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants