Skip to content

Manifest: Switch application key to browser_specific_settings #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2025
Merged

Manifest: Switch application key to browser_specific_settings #130

merged 2 commits into from
Jan 31, 2025

Conversation

Croydon
Copy link
Contributor

@Croydon Croydon commented Jan 29, 2025

Works with both Manifest v2 and v3, but required for v3. Partial fix for #50

@Croydon
Manifest: Switch application key to browser_specific_settings
2c933bf 
Works with both Manifest v2 and v3, but required for v3. Partial fix for rugk#50
@Croydon
Update all manifests
14cf5e9
rugk
rugk approved these changes Jan 31, 2025
View reviewed changes
Copy link
Owner

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Croydon,
first of all, thanks for your first contribution to this project! 🎉 👍 🏅
I hope you'll like this project and enjoy hacking on it… 😃

Thanks for this little patch, it's certainly appreciated!

@rugk rugk merged commit 2826bad into rugk:main Jan 31, 2025
@Croydon Croydon deleted the manifest_applications branch February 1, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rugk rugk rugk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Croydon @rugk