web: Bump webpack to 5.99.5

[danielhjacobs]

5.99.0 has regressions: webpack/webpack#19394

Unsure if it's causing issues for us, but figured an upgrade cannot hurt. Perhaps relates to #20045, but no actual idea nor any idea how to test that.

[torokati44]

Shall we maybe wait for the next release with webpack/webpack#19403 in it?

[torokati44]

It's already being cooked: https://github.com/webpack/webpack/actions/runs/14336658120

[torokati44]

And it's out: https://www.npmjs.com/package/webpack/v/5.99.3

[torokati44]

And it's at 5.99.5 now... 👀

[torokati44]

I took the liberty to amend this commit and the PR to update to webpack 5.99.5 - I hope you don't mind.

[danielhjacobs]

I suspect #20045 is related. I finally found a new issue that started April 8th. It affects the extension on all Chrome versions (you can see as an error by installing it via zip in Chrome). It ties to this code:

ruffle/web/packages/extension/src/background.ts

Lines 57 to 59 in 5aa7f02

	await utils.declarativeNetRequest.updateDynamicRules({
	removeRuleIds: [ruleId],
	});

Prior to April 8th, that line in background.js became this:

            await declarativeNetRequest.updateDynamicRules({
                removeRuleIds: [ruleId],
            });

As of the latest build, it's this:

            await utils.declarativeNetRequest.updateDynamicRules({
                removeRuleIds: [ruleId],
            });

There is an error "Uncaught (in promise) ReferenceError: utils is not defined"

The webpack issue, webpack/webpack#19394, is titled "Regression on v5.99.0, [something] not defined". The imports in the try/catch are replaced properly. The import in the finally is the issue.

Despite the ReferenceError occurring on all Chrome versions, it likely causes issues on specifically Chrome 121 - Chrome 127, the versions where the responseHeaders RuleCondition was recognized but not applied: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/HeaderInfo.

[danielhjacobs]

After all, if this rule is added but not removed on a browser that recognizes a responseHeaders RuleCondition but does not apply it, what happens (rhetorical)? Answer: Every resource is blocked:

ruffle/web/packages/extension/src/background.ts

Lines 37 to 50 in 5aa7f02

	await utils.declarativeNetRequest.updateDynamicRules({
	removeRuleIds: [ruleId],
	addRules: [
	{
	id: ruleId,
	condition: { responseHeaders: [] },
	action: {
	type:
	chrome.declarativeNetRequest.RuleActionType
	?.BLOCK ?? "block",
	},
	},
	],
	});

[torokati44]

I don't immediately see the connection between this rule, and the webpack issue that got fixed, but it's okay, I believe you!

[danielhjacobs]

Part of the webpack issue was not doing replacements that should be done for imports.

It's the fact that in the finally specifically await utils.declarativeNetRequest.updateDynamicRules did not get changed to await declarativeNetRequest.updateDynamicRules, as webpack is supposed to do. The issue isn't that the rulecondition is added, it's that it's added AND not removed (because of a ReferenceError).

[torokati44]

Ah, okay, alright, thanks! It makes sense now.