avm1: migrate StageObject to NativeObject
#20027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moulins
added
A-avm1
moulins
force-pushed
the
avm1-native-stage-object
branch
3 times, most recently
from
3a5b7a5 to
de66cf7
Compare
|
Shouldn't the text field binding functions be passed a |
Good point, I don't remember exactly why I did this, but it clearly serves no purpose in the final version of the code ^^ EDIT: now fixed. |
moulins
force-pushed
the
avm1-native-stage-object
branch
2 times, most recently
from
7e3277c to
cc20bc3
Compare
Lord-McSweeney
approved these changes
Apr 11, 2025
Affect DOs are: Avm1Button, EditText, MovieClip and Video
moulins
force-pushed
the
avm1-native-stage-object
branch
from
cc20bc3 to
edfa66d
Compare
moulins
added a commit
to moulins/ruffle
that referenced
this pull request
Apr 13, 2025
…hange` Fixes ruffle-rs#20080 (regresstion introduced by ruffle-rs#20027)
moulins
added a commit
to moulins/ruffle
that referenced
this pull request
Apr 13, 2025
…hange` Fixes ruffle-rs#20080, ruffle-rs#20104, etc... (regresstion introduced by ruffle-rs#20027)
moulins
added a commit
to moulins/ruffle
that referenced
this pull request
Apr 13, 2025
…hange` Fixes ruffle-rs#20080, ruffle-rs#20104, etc... (regression introduced by ruffle-rs#20027)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The display objects (
Avm1Button,EditText,MovieClip,Video) are directly stored asNativeObjectvariants of theirScriptObjects, and theStageObject-specific data (namely, the AVM1 text field binding list) is moved directly inside the DO structs.After this, only
SuperObjectwill be left as aObjectvariant.