Skip to content

feat: add support for updating records for stripe #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 25, 2023
Merged

feat: add support for updating records for stripe #30

merged 6 commits into from
Jan 25, 2023

Conversation

ssbeefeater
Copy link

Description

Add support for getting updates for incremental syncs for the following stripe resources using the event API

  1. charges
  2. customers
  3. disputes
  4. invoices
  5. invoice_items
  6. plans
  7. products
  8. subscriptions
  9. transfers

Docs

https://www.notion.so/rudderstacks/Stripe-updated-records-d1df062071b848cb87966c1b2d56f8a1
https://www.notion.so/rudderstacks/Stripe-APIs-and-Correct-ETL-WIP-3914e964880e43cfa5e4e09535fa8e1a

Ticket

Stripe: Add support for getting updated records

@github-actions
Copy link

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-tplcentral
  • source-mongodb-v2
  • source-zendesk-talk
  • source-prestashop
  • source-airtable
  • source-zendesk-sunshine
  • destination-aws-datalake
  • source-e2e-test-cloud
  • source-openweather
  • source-google-search-console
  • source-mongodb-strict-encrypt
  • source-retently
  • destination-oracle
  • source-surveymonkey
  • source-freshcaller
  • source-greenhouse
  • destination-elasticsearch-strict-encrypt
  • source-mssql-strict-encrypt
  • source-twilio
  • destination-bigquery
  • source-oracle-strict-encrypt
  • source-drift
  • destination-clickhouse
  • destination-mongodb
  • source-mysql-strict-encrypt
  • destination-elasticsearch
  • source-outreach
  • destination-redshift
  • destination-mssql-strict-encrypt
  • source-facebook-marketing
  • source-cockroachdb
  • destination-csv
  • source-cockroachdb-strict-encrypt
  • destination-snowflake
  • source-bigquery
  • source-github
  • destination-postgres
  • source-braintree
  • source-snowflake
  • source-lever-hiring
  • source-strava
  • source-mongodb
  • source-salesforce
  • source-instagram
  • destination-databricks
  • destination-r2
  • source-delighted
  • source-posthog
  • source-onesignal
  • source-notion
  • destination-meilisearch
  • source-clickhouse-strict-encrypt
  • source-db2
  • source-gitlab
  • source-google-ads
  • source-zenloop
  • source-amplitude
  • source-amazon-sqs
  • source-postgres-strict-encrypt
  • destination-scylla
  • source-commercetools
  • source-freshservice
  • destination-mysql
  • source-confluence
  • destination-pubsub
  • destination-keen
  • source-python-http-tutorial
  • destination-redis
  • source-recharge
  • source-sftp
  • source-appsflyer
  • source-amazon-seller-partner
  • source-mailchimp
  • destination-bigquery-denormalized
  • source-lemlist
  • destination-postgres-strict-encrypt
  • source-mssql
  • source-azure-table
  • destination-mariadb-columnstore
  • source-chargebee
  • source-oracle
  • source-alloydb-strict-encrypt
  • destination-cassandra
  • source-mysql
  • source-kafka
  • source-pardot
  • source-sendgrid
  • source-e2e-test
  • source-clickhouse
  • source-elasticsearch
  • source-amazon-ads
  • destination-mssql
  • destination-e2e-test
  • source-redshift
  • destination-oracle-strict-encrypt
  • source-pinterest
  • source-monday
  • source-youtube-analytics
  • source-harvest
  • source-relational-db
  • source-stock-ticker-api-tutorial
  • source-salesloft
  • source-sentry
  • destination-mongodb-strict-encrypt
  • source-klaviyo
  • destination-pulsar
  • destination-s3
  • source-quickbooks-singer
  • source-pipedrive
  • destination-kinesis
  • source-paystack
  • destination-dev-null
  • destination-jdbc
  • source-postgres
  • source-iterable
  • source-scaffold-java-jdbc
  • destination-tidb
  • source-tidb
  • destination-dynamodb
  • source-cart
  • source-facebook-pages
  • source-freshsales
  • source-asana
  • destination-clickhouse-strict-encrypt
  • source-mailgun
  • destination-kafka
  • destination-mysql-strict-encrypt
  • source-plaid
  • destination-local-json
  • destination-rockset
  • destination-azure-blob-storage
  • destination-gcs
  • source-okta
  • source-jdbc
  • source-linnworks
  • source-zoom-singer
  • destination-mqtt
  • source-db2-strict-encrypt
  • source-alloydb

am6010
am6010 reviewed Oct 27, 2022
View reviewed changes
Copy link

@am6010 am6010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good! I have some minor questions.

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-rockset
  • source-strava
  • source-zendesk-talk
  • source-cockroachdb-strict-encrypt
  • source-delighted
  • destination-kafka
  • source-gitlab
  • source-db2
  • source-oracle
  • destination-pubsub
  • destination-bigquery-denormalized
  • source-tplcentral
  • source-lever-hiring
  • source-posthog
  • source-python-http-tutorial
  • destination-gcs
  • destination-mqtt
  • source-zoom-singer
  • source-kafka
  • source-google-search-console
  • destination-mongodb-strict-encrypt
  • source-snowflake
  • destination-azure-blob-storage
  • destination-mysql-strict-encrypt
  • source-e2e-test
  • source-postgres-strict-encrypt
  • source-zenloop
  • source-linnworks
  • destination-redis
  • source-okta
  • destination-postgres
  • source-amazon-sqs
  • source-alloydb
  • source-sentry
  • source-cart
  • destination-mssql
  • source-clickhouse
  • source-db2-strict-encrypt
  • source-lemlist
  • source-sendgrid
  • destination-postgres-strict-encrypt
  • source-asana
  • source-stock-ticker-api-tutorial
  • destination-oracle-strict-encrypt
  • source-braintree
  • source-mongodb
  • source-mailchimp
  • source-commercetools
  • source-salesforce
  • source-iterable
  • source-airtable
  • source-redshift
  • source-surveymonkey
  • destination-e2e-test
  • destination-elasticsearch-strict-encrypt
  • destination-mssql-strict-encrypt
  • destination-csv
  • source-quickbooks-singer
  • source-drift
  • destination-s3
  • source-openweather
  • destination-oracle
  • destination-meilisearch
  • source-bigquery
  • source-recharge
  • source-github
  • source-greenhouse
  • source-zendesk-sunshine
  • source-azure-table
  • source-salesloft
  • source-cockroachdb
  • destination-pulsar
  • source-mssql-strict-encrypt
  • source-instagram
  • source-monday
  • source-mysql
  • source-retently
  • destination-cassandra
  • destination-clickhouse-strict-encrypt
  • source-e2e-test-cloud
  • source-onesignal
  • destination-mysql
  • destination-elasticsearch
  • source-pipedrive
  • source-alloydb-strict-encrypt
  • source-sftp
  • source-mongodb-v2
  • destination-aws-datalake
  • source-clickhouse-strict-encrypt
  • source-prestashop
  • source-paystack
  • source-relational-db
  • source-facebook-marketing
  • source-mailgun
  • source-freshservice
  • source-google-ads
  • destination-jdbc
  • destination-mariadb-columnstore
  • destination-r2
  • source-mssql
  • source-oracle-strict-encrypt
  • source-tidb
  • destination-scylla
  • destination-kinesis
  • destination-tidb
  • destination-dynamodb
  • destination-dev-null
  • source-amazon-seller-partner
  • source-pardot
  • destination-redshift
  • destination-snowflake
  • source-appsflyer
  • source-mongodb-strict-encrypt
  • source-chargebee
  • source-elasticsearch
  • source-scaffold-java-jdbc
  • source-mysql-strict-encrypt
  • destination-clickhouse
  • source-notion
  • source-facebook-pages
  • source-confluence
  • source-pinterest
  • source-klaviyo
  • destination-mongodb
  • source-outreach
  • source-plaid
  • destination-bigquery
  • source-freshcaller
  • source-youtube-analytics
  • source-amplitude
  • source-freshsales
  • source-amazon-ads
  • destination-keen
  • source-postgres
  • source-jdbc
  • destination-databricks
  • destination-local-json
  • source-twilio
  • source-harvest

@ssbeefeater ssbeefeater requested a review from am6010 November 4, 2022 13:34
RanjeetMishra
RanjeetMishra reviewed Nov 7, 2022
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

Sources (95)
  • source-iterable
  • source-tplcentral
  • source-recharge
  • source-youtube-analytics
  • source-surveymonkey
  • source-retently
  • source-strava
  • source-asana
  • source-oracle-strict-encrypt
  • source-onesignal
  • source-paystack
  • source-sendgrid
  • source-snowflake
  • source-mongodb-strict-encrypt
  • source-notion
  • source-drift
  • source-amplitude
  • source-amazon-sqs
  • source-postgres-strict-encrypt
  • source-oracle
  • source-mssql
  • source-lever-hiring
  • source-cockroachdb
  • source-mysql
  • source-azure-table
  • source-sentry
  • source-commercetools
  • source-postgres
  • source-e2e-test
  • source-pinterest
  • source-google-search-console
  • source-pipedrive
  • source-mongodb
  • source-twilio
  • source-sftp
  • source-redshift
  • source-scaffold-java-jdbc
  • source-amazon-seller-partner
  • source-amazon-ads
  • source-mongodb-v2
  • source-python-http-tutorial
  • source-elasticsearch
  • source-mssql-strict-encrypt
  • source-freshsales
  • source-cart
  • source-zendesk-sunshine
  • source-instagram
  • source-clickhouse-strict-encrypt
  • source-facebook-pages
  • source-pardot
  • source-braintree
  • source-tidb
  • source-openweather
  • source-stock-ticker-api-tutorial
  • source-plaid
  • source-linnworks
  • source-chargebee
  • source-zendesk-talk
  • source-db2-strict-encrypt
  • source-confluence
  • source-monday
  • source-salesloft
  • source-freshcaller
  • source-gitlab
  • source-facebook-marketing
  • source-harvest
  • source-alloydb
  • source-outreach
  • source-alloydb-strict-encrypt
  • source-e2e-test-cloud
  • source-bigquery
  • source-mysql-strict-encrypt
  • source-appsflyer
  • source-google-ads
  • source-jdbc
  • source-klaviyo
  • source-okta
  • source-zenloop
  • source-kafka
  • source-salesforce
  • source-quickbooks-singer
  • source-delighted
  • source-github
  • source-posthog
  • source-airtable
  • source-freshservice
  • source-db2
  • source-cockroachdb-strict-encrypt
  • source-mailgun
  • source-mailchimp
  • source-greenhouse
  • source-lemlist
  • source-relational-db
  • source-clickhouse
  • source-prestashop
Destinations (43)
  • destination-mongodb-strict-encrypt
  • destination-mssql
  • destination-bigquery-denormalized
  • destination-bigquery
  • destination-jdbc
  • destination-local-json
  • destination-yugabytedb
  • destination-azure-blob-storage
  • destination-csv
  • destination-postgres-strict-encrypt
  • destination-mongodb
  • destination-clickhouse-strict-encrypt
  • destination-oracle-strict-encrypt
  • destination-gcs
  • destination-redis
  • destination-databricks
  • destination-mqtt
  • destination-r2
  • destination-dev-null
  • destination-scylla
  • destination-rockset
  • destination-kinesis
  • destination-pubsub
  • destination-mssql-strict-encrypt
  • destination-dynamodb
  • destination-e2e-test
  • destination-tidb
  • destination-cassandra
  • destination-mysql
  • destination-redshift
  • destination-postgres
  • destination-elasticsearch
  • destination-mariadb-columnstore
  • destination-clickhouse
  • destination-mysql-strict-encrypt
  • destination-snowflake
  • destination-oracle
  • destination-pulsar
  • destination-aws-datalake
  • destination-s3
  • destination-elasticsearch-strict-encrypt
  • destination-kafka
  • destination-keen

am6010
am6010 reviewed Jan 16, 2023
View reviewed changes
Copy link

@am6010 am6010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr looks good. Nice work.
I have some suggestions.
Also, I have a question. If we get an update event for an existing row will the event have the only new value to update the entry in the warehouse?

am6010
am6010 approved these changes Jan 18, 2023
View reviewed changes
Copy link

@am6010 am6010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ssbeefeater ssbeefeater merged commit 8f8e52d into main Jan 25, 2023
@ssbeefeater ssbeefeater deleted the source-stripe-update branch January 25, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RanjeetMishra RanjeetMishra RanjeetMishra left review comments

@nidhilashkari17 nidhilashkari17 nidhilashkari17 left review comments

@am6010 am6010 am6010 approved these changes

@chaitanyapraveen chaitanyapraveen Awaiting requested review from chaitanyapraveen

Assignees
No one assigned
Labels
area/connectors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ssbeefeater @am6010 @RanjeetMishra @nidhilashkari17