Skip to content

CI: Improve Security Posture #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025
Merged

CI: Improve Security Posture #356

merged 2 commits into from
Jul 3, 2025

Conversation

tisba
Copy link
Collaborator

@tisba tisba commented Jul 3, 2025

I recently read a couple of GH action security articles and thought it might be worth applying some of the findings here.

  • Dropping default permissions of GH token via permissions: {}
  • actions/checkout: Opt-out of persisting git credentials as we only checkout code. From the https://github.com/actions/checkout:

    The auth token is persisted in the local git config. This enables your scripts to run authenticated git commands. The token is removed during post-job cleanup. Set persist-credentials: false to opt-out.

  • pin actions to their git SHA, rather than a floating tag. Using # v4 after the definition, allows Dependabot to still update those. This way we know exactly which action we're using.

@tisba tisba merged commit ab2384e into main Jul 3, 2025
28 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant