Skip to content

Support markdown syntax in table cells #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

Support markdown syntax in table cells #1386

merged 1 commit into from
Jul 3, 2025

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jul 2, 2025

This will allow things like backticks and links being rendered in table cells.

Fixes #1233

Before

Screenshot 2025-07-02 at 21 57 59

After

Screenshot 2025-07-02 at 21 56 52

@st0012 st0012 added the bug label Jul 2, 2025
@st0012 st0012 requested review from tompng and vinistock July 2, 2025 20:58
Copy link

cloudflare-workers-and-pages bot commented Jul 2, 2025

Deploying rdoc with  Cloudflare Pages  Cloudflare Pages

Latest commit: b7e3ba6
Status: ✅  Deploy successful!
Preview URL: https://0c81cbc6.rdoc-6cd.pages.dev
Branch Preview URL: https://fix--13769.rdoc-6cd.pages.dev

View logs

@matzbot
Copy link
Collaborator

matzbot commented Jul 2, 2025

🚀 Preview deployment available at: https://ae32a0e5.rdoc-6cd.pages.dev (commit: 6a69bfc)

Copy link
Member

@nobu nobu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing spaces.

@st0012
Copy link
Member Author

st0012 commented Jul 3, 2025

@nobu Thanks I've removed them 👍

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

This will allow things like backticks and links being rendered in table cells.
@st0012 st0012 requested a review from tompng July 3, 2025 10:36
Copy link
Member

@tompng tompng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@st0012 st0012 merged commit eaac67d into master Jul 3, 2025
62 checks passed
@st0012 st0012 deleted the fix-#13769 branch July 3, 2025 19:22
@st0012 st0012 mentioned this pull request Jul 3, 2025
st0012 added a commit that referenced this pull request Jul 3, 2025
v6.14.1...master but mostly for
#1386 which can immediately improve `ruby/ruby`'s documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links and code blocks in markdown table aren't rendered correctly
5 participants