Designated initializers #2131
Merged
Designated initializers #2131
+103
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
force-pushed
the
designated_initializers
branch
from
4077aae to
7bda0bf
Compare
amomchilov
commented
Dec 6, 2024
Comment on lines
-57
to
-61
| check_children_cap(loc); | ||
|
|
||
| unsigned short i = loc->children->len++; | ||
| loc->children->entries[i].name = name; | ||
| loc->children->entries[i].rg = rbs_new_loc_range(r); |
There was a problem hiding this comment.
This code is the same as rbs_loc_add_optional_child, so we can reuse that, and just set required_p after.
| *self_loc = (rbs_loc) { | ||
| .buffer = other_loc->buffer, | ||
| .rg = other_loc->rg, | ||
| .children = NULL, |
There was a problem hiding this comment.
Not technically necessary, but IMO explicit+clear > implicit+terse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes several repeated assignments with C99 designated initializers.
We're already requiring C99 (well, the GNU dialect of it), so there shouldn't be any compiler versioning concerns:
rbs/ext/rbs_extension/extconf.rb
Line 13 in 4077aae
These have 3 benefits:
calloc, since they automatically zero-out any fields that that weren't explicitly set.