Skip to content

Refactor gemspec #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Refactor gemspec #17

merged 1 commit into from
Feb 29, 2024

Conversation

mblumtritt
Copy link
Contributor

  • remove unnecessary files
  • remove reference to not included executables
  • add bug tracker URL

@hsbt
Copy link
Member

hsbt commented Feb 29, 2024

Don't change quote style.

@mblumtritt
Copy link
Contributor Author

@hsbt

Don't change quote style.

Is there any good reason to keep the quote style?

The change was made/suggested by ruby-syntax-tree. Other linter like RuboCop etc. suggest the same…

@hsbt
Copy link
Member

hsbt commented Feb 29, 2024

I always use double-quote for string literal because I will leave from like this discussion.

@mblumtritt
Copy link
Contributor Author

I always use double-quote for string literal because I will leave from like this discussion.

Ok - I can change back to double quotes. But what about line 22? This already used single quotes.

@hsbt
Copy link
Member

hsbt commented Feb 29, 2024

But what about line 22? This already used single quotes.

Thanks for point that. Can you update it with double quote?

- remove unnecessary files
- remove reference to not included executables
- add bug tracker URL
@mblumtritt
Copy link
Contributor Author

Cleaned.

@hsbt hsbt merged commit 8bb86ee into ruby:master Feb 29, 2024
@hsbt
Copy link
Member

hsbt commented Feb 29, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants