WIP: Kill a debuggee process fastly if a test fails #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ono-max
changed the title
st0012
reviewed
Mar 20, 2023
| kill_safely pid, :debugger, test_info, sec: 0 | ||
| end | ||
| if name = test_info.failed_process && !is_fail | ||
| flunk(create_message("Expected the #{name} program to finish", test_info)) |
There was a problem hiding this comment.
If we only enter this case when is_fail is false, wouldn't name always be remote 🤔
| @@ -195,12 +195,20 @@ def run_test_scenario cmd, test_info | |||
| # result of `gets` return this exception in some platform | |||
| rescue Timeout::Error | |||
| assert_block(create_message("TIMEOUT ERROR (#{TIMEOUT_SEC} sec)", test_info)) { false } | |||
| rescue Test::Unit::AssertionFailedError | |||
| is_fail = true | |||
There was a problem hiding this comment.
Can we align the name with what we have in protocol test case (is_assertion_failure)?
| # kill debug console process | ||
| read.close | ||
| write.close | ||
| kill_safely pid, :debugger, test_info | ||
| if is_fail == true |
There was a problem hiding this comment.
The == true seems to be redundant?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your Pull Request 🎉
Please follow these instructions to help us review it more efficiently:
Description
Describe your changes: