Skip to content

disabling/removing break points via browser devtools doesn't seem to work #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kikonen opened this issue Feb 21, 2023 · 5 comments
Closed
Assignees

Comments

@kikonen
Copy link

kikonen commented Feb 21, 2023

Your environment

  • ruby -v: 3.2.1
  • rdbg -v: 1.7.1

Describe the bug

Breakpoint handling doesn't seem to work well with devtools integration. It seems that breakpoints can be added, but not disabled nor removed (i.e. they get disabled removed in browser devtools, but not in debug gem side in ruby process)

To Reproduce

Expected behavior

Have disable/enable of break points work

Additional context

In case it affects, running app inside docker container, and browser in localhost, rdbg port forwarded from docker container to localhost

@ono-max
Copy link
Member

ono-max commented Feb 21, 2023

Thank you for reporting.
Could you show us the sample program to reproduce this problem?

@kikonen
Copy link
Author

kikonen commented Feb 21, 2023

Unfortunately that may not be possible, since cannot share app where I was trying this out

@ono-max
Copy link
Member

ono-max commented Mar 7, 2023

I see. Could you check the following steps?

a=1
b=2
c=3
  1. Run $ rdbg target.rb --open=chrome
  2. Set a breakpoint at line 2.
  3. Execute the program.

In my environment, removing break points via the browser works.

@kikonen
Copy link
Author

kikonen commented Mar 7, 2023

I may try sometime, but I already pretty much gave up trying with this "devtools" approach due to #902 (which made approach highly inpractical with docker container, which was having process constantly restarted with "rerun", more precisely multiple processes in different containers), and #901 and #904. Aka. I',m back using just plain CLI with remote debug.

@ono-max
Copy link
Member

ono-max commented Mar 29, 2023

I think that #948 fixes this problem.

If you have any problem, please reopen or mention me. Thank you.

@ono-max ono-max closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants