Skip to content

[Fix #1353] Fix incorrect escaping of asterisk in docs and comments #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

hatsu38
Copy link
Contributor

@hatsu38 hatsu38 commented Mar 25, 2025

Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.

Fixes #1353


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

After in local

スクリーンショット 2025-03-26 0 42 48

This cop's autocorrection is unsafe because it turns a quoted `*` into
an SQL `*`, unquoted. `*` is a valid column name in certain databases
This cop's autocorrection is unsafe because it turns a quoted `\*` into
an SQL `*`, unquoted. `\*` is a valid column name in certain databases
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As indicated at the top of the file, this document is auto-generated and does not need to be updated manually.
https://raw.githubusercontent.com/rubocop/rubocop-rails/refs/tags/v2.30.3/docs/modules/ROOT/pages/cops_rails.adoc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I overlooked the notice at the beginning of the file. Sorry about that! I've made the corrections again.
c222756

@hatsu38 hatsu38 force-pushed the fix-broken-Rails_ArelStar-adoc branch from 9ac2e1d to c222756 Compare March 26, 2025 04:18
@koic koic merged commit 6b32cfb into rubocop:master Mar 29, 2025
16 checks passed
@hatsu38 hatsu38 deleted the fix-broken-Rails_ArelStar-adoc branch April 1, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken documentation for Rails/ArelStar
2 participants