Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up rubocop/rubocop-ast#277
In Prism (
Prism::Translation::Parser
),match-with-lvasgn
can be distinctly differentiated.It is unclear whether to conform to the current behavior of the Parser gem, but initially,
def_node_matcher
has been updated to accept the following incompatibilities forPerformance/EndWith
,Performance/StringInclude
, andPerformance/StartWith
cops to ensure it works with Prism 0.24.0 as well.Parser gem
Returns an
match_with_lvasgn
node:Returns an
match_with_lvasgn
node:This lvar-injecting feature appears to have not been supported by Parser gem for a long time: whitequark/parser#69 (comment)
Prism
Returns an
send
node:Returns an
match_with_lvasgn
node:Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.