sunmoonpos_eci: declare epv00 and moon98 prototypes #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ourairquality
force-pushed
the
sunmoonpos-sofa-decl
branch
from
96e3c39 to
0a7edfa
Compare
ourairquality
changed the title
|
Thanks for your timely help. I try to fix it by just rename the two funtion in src/sofa.c, also work. |
|
Renaming these in sofa.c just leaves the empty definitions in rtkcmd.c which will leave that function broken. |
liusheng2020
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a merge issue with the sofa changes. The functions epv00 and moon98 are defined in
src/sofa.cand need only be declared in rtkcm.c. If there is a compilation issue with these not being defined then the build definitions need to be updated to also include src/sofa.c, and hopefully someone can address that for the windows builds if that was the issue.