This repository was archived by the owner on Oct 27, 2020. It is now read-only.
Add support for multilingual gitbooks #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aniav thanks for PR. :-) I never used multilingual feature of gitbook so no idea if PR is correct. I am copying @SamyPesse. May be he can guide. |
|
This will not work with GitBook 2.0.0, but I'm going to add back support for @aniav you should use: var path = require("path");
...
path.relative(this.options.originalInput, page.rawPath) |
SamyPesse
added a commit
to GitbookIO/gitbook
that referenced
this pull request
Mar 30, 2015
|
I have updated the file with your suggestion. Thank you! ✨ |
|
You're welcome 👍 |
|
@rahul286 I believe this can be merged now :) |
|
👍 and gitbook 2.0.1 has been released and is in production on gitbook.com to handle |
rahul286
added a commit
that referenced
this pull request
Apr 3, 2015
Add support for multilingual gitbooks
|
@aniav and @SamyPesse thanks. :-) Merged PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our multilingual book: https://github.com/DjangoGirls/ your plugin was generating wrong links, without the language prefix. I have created this change and as far as I checked it works properly with plain books and with the multilingual ones, but I am not sure how much "hacky" this solution is. I am not sure how gitbook handles languages.
Any comments are much appreciated. Thank you!