Building with "--enable-debug" will fail: enc_xml.c:202:2: error: too few arguments to function 'json_object_is_type'

[Whissi]

Building liblognorm-1.0.x will fail when "--enable-debug" switch is set:

[...]
enc_syslog.c: In function 'ln_fmtEventToRFC5424':
enc_syslog.c:186:2: warning: 'json_object_object_get' is deprecated (declared at /usr/include/json-c/json_object.h:290)
[-Wdeprecated-declarations]
  if((tags = json_object_object_get(json, "event.tags")) != NULL) {
  ^
x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..  -I.. -I/usr/include/json-c     -O2 -pipe -march=core-avx-i
-mno-movbe -mno-abm -mno-lwp -mno-fma -mno-fma4 -mno-xop -mno-bmi -mno-bmi2 -mno-tbm -mno-avx2 -mno-lzcnt --param l1-cac
he-size=32 --param l1-cache-line-size=64 --param l2-cache-size=8192 -mtune=generic -W -Wall -Wformat-security -Wshadow -
Wcast-align -Wpointer-arith -Wmissing-format-attribute -g -c -o lognormalizer-lognormalizer.o `test -f 'lognormalizer.c'
 || echo './'`lognormalizer.c
enc_csv.c: In function 'ln_fmtEventToCSV':
enc_csv.c:200:3: warning: 'json_object_object_get' is deprecated (declared at /usr/include/json-c/json_object.h:290) [-W
deprecated-declarations]
   field = json_object_object_get(json, name);
   ^
libtool: compile:  x86_64-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I/usr/include/json-c -O2 -pipe -march=co
re-avx-i -mno-movbe -mno-abm -mno-lwp -mno-fma -mno-fma4 -mno-xop -mno-bmi -mno-bmi2 -mno-tbm -mno-avx2 -mno-lzcnt --par
am l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=8192 -mtune=generic -W -Wall -Wformat-security -
Wshadow -Wcast-align -Wpointer-arith -Wmissing-format-attribute -g -c enc_xml.c  -fPIC -DPIC -o .libs/liblognorm_la-enc_
xml.o
lognormalizer.c: In function ‘eventHasTag’:
lognormalizer.c:115:2: warning: ‘json_object_object_get’ is deprecated (declared at /usr/include/json-c/json_object.h:29
0) [-Wdeprecated-declarations]
  if ((tagbucket = json_object_object_get(json, "event.tags")) != NULL) {
  ^
lognormalizer.c: In function ‘normalize’:
lognormalizer.c:155:7: warning: ‘json_object_object_get’ is deprecated (declared at /usr/include/json-c/json_object.h:29
0) [-Wdeprecated-declarations]
       && json_object_object_get(json, "unparsed-data") != NULL) {
       ^
enc_xml.c: In function 'ln_fmtEventToXML':
enc_xml.c:202:2: warning: passing argument 1 of 'json_object_is_type' makes pointer from integer without a cast [enabled
 by default]
  assert(json_object_is_type(json_type_object));
  ^
In file included from /usr/include/json-c/linkhash.h:16:0,
                 from /usr/include/json-c/json.h:22,
                 from enc_xml.c:42:
/usr/include/json-c/json_object.h:143:12: note: expected 'struct json_object *' but argument is of type 'int'
 extern int json_object_is_type(struct json_object *obj, enum json_type type);
            ^
enc_xml.c:202:2: error: too few arguments to function 'json_object_is_type'
  assert(json_object_is_type(json_type_object));
  ^
In file included from /usr/include/json-c/linkhash.h:16:0,
                 from /usr/include/json-c/json.h:22,
                 from enc_xml.c:42:
/usr/include/json-c/json_object.h:143:12: note: declared here
 extern int json_object_is_type(struct json_object *obj, enum json_type type);
            ^
enc_xml.c:208:2: warning: 'json_object_object_get' is deprecated (declared at /usr/include/json-c/json_object.h:290) [-W
deprecated-declarations]
  if((tags = json_object_object_get(json, "event.tags")) != NULL) {
  ^
Makefile:592: recipe for target 'liblognorm_la-enc_xml.lo' failed
make[2]: *** [liblognorm_la-enc_xml.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/var/tmp/portage/dev-libs/liblognorm-1.0.1/work/liblognorm-1.0.1/src'
Makefile:451: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/dev-libs/liblognorm-1.0.1/work/liblognorm-1.0.1'
Makefile:359: recipe for target 'all' failed
make: *** [all] Error 2

Tested with liblognorm-1.0.0 and liblognorm-1.0.1.

[rgerhards]

To be released with 1.0.2. There seems to be no urgency for this fix. Let us know if you think there is.