support netty boringssl aarch_64 classifier #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sullis <[email protected]>
|
WDYT? @OlegDokuka |
|
Ready for review |
OlegDokuka
approved these changes
Jan 24, 2025
|
@sullis apologies for the delay, and thank you for your contribution 🫶 |
rstoyanchev
pushed a commit
that referenced
this pull request
Jan 27, 2025
Signed-off-by: sullis <[email protected]>
|
Fixed in a5fbd96. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support netty boringssl aarch_64
Motivation:
Netty boringssl is available on arm64 (aarch_64)
Let's use the proper classifier.
Modifications:
update build.gradle
Result:
Correct artifact is observed on MacOS arm64 laptop.