Skip to content

SUIDPermissionsCheck: Check for permctl instead of chkstat #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

scabrero
Copy link
Contributor

W: permissions-missing-verifyscript is incorrectly reported.

Related to #1292

@scabrero
Copy link
Contributor Author

Example from https://build.opensuse.org/build/openSUSE:Factory/standard/x86_64/sssd/_log:

[  122s] sssd.x86_64: W: permissions-missing-verifyscript missing %verify_permissions -e /usr/libexec/sssd/selinux_child
[  122s] sssd.x86_64: W: permissions-missing-verifyscript missing %verify_permissions -e /usr/libexec/sssd/sssd_pam
[  122s] sssd-krb5-common.x86_64: W: permissions-missing-verifyscript missing %verify_permissions -e /usr/libexec/sssd/krb5_child
[  122s] sssd-krb5-common.x86_64: W: permissions-missing-verifyscript missing %verify_permissions -e /usr/libexec/sssd/ldap_child
[  122s] Please add a %verifyscript section

@scabrero scabrero force-pushed the fix-permctl-verifyscript branch from 8ef37e8 to 320c63e Compare March 20, 2025 07:31
Copy link
Member

@danigm danigm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a simple comment to escape the path before using it in the regex.

W: permissions-missing-verifyscript is incorrectly reported.

Related to rpm-software-management#1292

Signed-off-by: Samuel Cabrero <[email protected]>
@scabrero scabrero force-pushed the fix-permctl-verifyscript branch from 320c63e to e950414 Compare May 20, 2025 11:35
@danigm danigm self-requested a review May 20, 2025 11:50
Copy link
Member

@danigm danigm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danigm danigm merged commit a90a532 into rpm-software-management:opensuse May 27, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants