Change log message to STATUS #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge J. Perez <[email protected]>
|
@clalancette PTAL |
|
fyi: @Crola1702 After this PR and eProsima/Fast-DDS#5125, performance tests CI on rolling should be green. EDIT: nvm, 4 errors were introduced in build 66 https://build.ros2.org/view/Rci/job/Rci__nightly-performance_ubuntu_noble_amd64/66/, we'll take a look to those afterwards. |
clalancette
approved these changes
Aug 6, 2024
|
CI looks good; we are down to 2 warnings in the code for Clang-tidy, but all CMake warnings are gone. So I'm going ahead and merging this one. |
Blast545
added a commit
to Blast545/performance_test
that referenced
this pull request
Aug 9, 2024
Signed-off-by: Jorge J. Perez <[email protected]>
Blast545
added a commit
to Blast545/performance_test
that referenced
this pull request
Aug 9, 2024
Signed-off-by: Jorge J. Perez <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Change log message to STATUS (#54) * Fix cpplint build/include_order errors (#53) * Fix cpplint build/include_order errors * Fix uncrustify parenthesis Signed-off-by: Jorge J. Perez <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Change log message to STATUS (#54) * Fix cpplint build/include_order errors (#53) * Fix cpplint build/include_order errors * Fix uncrustify parenthesis Signed-off-by: Jorge J. Perez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to status message. Build has been using the bundled
fastrtpsgen, so the job shouldn't generate a warning about it.Reference conversation: https://osrf.slack.com/archives/C04R65U5CNA/p1721769869944609
CMake warnings to be fixed after this is merged: https://build.ros2.org/view/Rci/job/Rci__nightly-performance_ubuntu_noble_amd64/68/cmake/