Fixes for #1275 and #1365 #1423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4hn
reviewed
Sep 9, 2019
|
Thanks for implementing the special handling for STL, I was going to do it the same way. 👍 Generally speaking while this is perfectly compatible with the previous stl loader I wonder about one thing:
As I'm at home with a cold I have only slightly tested this code with publicly available data. I'm fine with merging as is but would like to wait with the release a few more days to get better testing. [1] assimp supports stl files with color data but I have not yet encountered one in the wild ... |
simonschmeisser
approved these changes
Sep 9, 2019
rhaschke
force-pushed
the
melodic-devel
branch
3 times, most recently
from
0467a29 to
e0a7cf4
Compare
|
I did some testing on our actual software and so far it looks good 👍 |
- invalid quaternion: issue warning only - triangle list accepts points.size()/3 colors as well (face colors) - don't create text marker for interactive marker control with empty description - allow more fine-grained log levels - distinguish all ros::console::levels - issue rviz status warning for any message, but avoid cluttering the console - use logger namespace to allow disabling console output
rhaschke
force-pushed
the
melodic-devel
branch
from
e0a7cf4 to
06539cb
Compare
|
I added another fixup for #1275 according to #1120 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some more issues of #1275:
(to avoid warning)
as well as #1365:
@v4hn and @simonschmeisser, could you please have a look?