Skip to content

check length of display-config parameter before extracting substring #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2018
Merged

check length of display-config parameter before extracting substring #1189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rviz/visualizer_app.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ bool VisualizerApp::init( int argc, char** argv )
if (vm.count("display-config"))
{
display_config = vm["display-config"].as<std::string>();
if( display_config.substr( display_config.size() - 4, 4 ) == ".vcg" )
if (display_config.size() >= 4 && display_config.substr( display_config.size() - 4, 4 ) == ".vcg")
{
std::cerr << "ERROR: the config file '" << display_config << "' is a .vcg file, which is the old rviz config format." << std::endl;
std::cerr << " New config files have a .rviz extension and use YAML formatting. The format changed" << std::endl;
Expand Down