check length of display-config parameter before extracting substring #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
reviewed
Jan 28, 2018
src/rviz/visualizer_app.cpp
Outdated
| @@ -172,7 +172,7 @@ bool VisualizerApp::init( int argc, char** argv ) | |||
| if (vm.count("display-config")) | |||
| { | |||
| display_config = vm["display-config"].as<std::string>(); | |||
| if( display_config.substr( display_config.size() - 4, 4 ) == ".vcg" ) | |||
| if (display_config.size() >= 4 and display_config.substr( display_config.size() - 4, 4 ) == ".vcg" ) | |||
There was a problem hiding this comment.
Please use &&. Also, I know the rviz style is weird, but please preserve the whitespace when possible, should be if ( dis... if you like.
There was a problem hiding this comment.
Shall I switch to if ( dis... even if (almost) the entire rest of the file does not use this style or shall I reformat the file this way?
There was a problem hiding this comment.
Nah, that's ok, it's pretty inconsistent in this version anyways.
dseifert
force-pushed
the
fix-segfault-on-short-display-config
branch
from
b002d62 to
2275eab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
rviz -d bla, rviz would segfault as it tried to extract a substring of the display-config parameter without checking its size first.