-
Notifications
You must be signed in to change notification settings - Fork 71
Melodic/Noetic support #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@knorth55 can you check if this works on your complex smach example? on both Meldoic / Noetic. |
smach_viewer/scripts/smach_viewer.py
Outdated
except KeyError: | ||
local_data = pickle.loads(base64.b64decode(msg.local_data.encode('utf-8'))) | ||
if isinstance(msg.local_data, str): | ||
local_data = pickle.loads(base64.b64decode(msg.local_data)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this chage causes error in melodic
.
[ERROR] [1658322156.379389]: bad callback: <bound method SmachViewerFrame._status_msg_update of <__main__.SmachViewerFrame; proxy of <Swig Object of type 'wxFrame *' at 0x55a2221c2ce0> >>
Traceback (most recent call last):
File "/opt/ros/melodic/lib/python2.7/dist-packages/rospy/topics.py", line 750, in _invoke_callback
cb(msg)
File "/home/knorth55/ros/melodic/src/ros-visualization/executive_smach_visualization/smach_viewer/scripts/smach_viewer.py", line 879, in _status_msg_update
if container.update_status(msg):
File "/home/knorth55/ros/melodic/src/ros-visualization/executive_smach_visualization/smach_viewer/scripts/smach_viewer.py", line 217, in update_status
self._local_data._data = self._load_local_data(msg)
File "/home/knorth55/ros/melodic/src/ros-visualization/executive_smach_visualization/smach_viewer/scripts/smach_viewer.py", line 191, in _load_local_data
local_data = pickle.loads(base64.b64decode(msg.local_data))
File "/usr/lib/python2.7/base64.py", line 78, in b64decode
raise TypeError(msg)
TypeError: Incorrect padding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked yet, but this may be caused by multibyte language...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it is not related to multibyte language.
we have same error with roseus_smach/sample/state-machine-ros-sample.l
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fixed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thank you.
Noetic is not yet tested, but I tested in Melodic. I tried with english (singlebyte language) and it works in Melodic.
|
@knorth55 If you revert, you can show Japanese on melodic
|
works.
does not works. So, we should modify |
[WIP] fix for multibyte language
rework of #39, as #39 mixes style change and noetic support, it also drop meldoic support.