-
Notifications
You must be signed in to change notification settings - Fork 61
Add option to set ssh port for servers using non-standard SSH port #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2dbc144
to
22eada6
Compare
22eada6
to
316520d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
==========================================
- Coverage 25.15% 24.84% -0.31%
==========================================
Files 2 2
Lines 322 326 +4
Branches 86 88 +2
==========================================
Hits 81 81
- Misses 241 245 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Romain Reignier <[email protected]>
316520d
to
1d4389c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me. I just have a minor request.
@@ -118,6 +118,13 @@ inputs: | |||
Scheduled events default to latest commit of default branch. | |||
Set this if you want the scheduled job to run on on a specific branch. | |||
required: false | |||
ssh-port: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think git-ssh-port
would be a bit more descriptive, for the input name here and for the variable (gitSshPort
) in src/action-ros-ci.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a good idea.
I won't be able to make the change this week but will try I soon as I can or feel free to do it.
Hi dear maintainers,
I know that this action has been developed exclusively to be used on Github.
But other forges like Forgejo provide actions runners compatible with the Github ones.
I have been able to use your action on a private Forgejo instance but on my server, the SSH port of the Git server is not the default port 22. Hence my rosinstall files contains ssh urls with a specific port, in the format:
instead of the Github:
By adding the
ssh-port
input for the action, I have managed to adapt the url replaced with theinsteaof
git config to make it work for my use-case.Because the git url with a port has already a trailing
/
like on HTTPS urls, the config entry is the same, hence the--add
argument in that case.I have not added an entry in the README because this is an advanced usage of the action and it is documented in
action.yml
.I have been able to test this change both on my private Forgejo setup and on Github with a private repo with ssh url in the rosinstall.