Test also for the inactive controller #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
DasRoteSkelett,
destogl,
erickisos,
livanov93,
LukasMacha97,
peterdavidfagan and
saikishor
saikishor
previously approved these changes
Mar 30, 2025
saikishor
approved these changes
Mar 30, 2025
mergify bot
pushed a commit
that referenced
this pull request
Mar 30, 2025
(cherry picked from commit 93b2f12)
christophfroehlich
added a commit
that referenced
this pull request
Mar 30, 2025
(cherry picked from commit 93b2f12) Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ros-controls/ros2_control_ci#287
the test finished sending SIGINTs to all processes, but the spawner for the inactive controller was not finished yet. If we check also for the inactive controller to be spawend, this should not happen anymore.