-
Notifications
You must be signed in to change notification settings - Fork 232
[example_9] Add gazebo bridge node for clock sync-ing #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Mergifyio backport mergify/bp/humble/pr-482 |
✅ Backports have been created
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, you are totally right.
I'm just wondering why the test succeeds without your changes, this should not happen. Calling manually the same as within the test fails:
ros2 launch ros2_control_demo_example_9 rrbot_gazebo.launch.py gui:=false
2587970
into
ros-controls:master
(cherry picked from commit 2587970)
Ah, we are testing only the rrbot.launch.py without gazebo 🙈 |
(cherry picked from commit 2587970) Co-authored-by: Julia Jia <[email protected]>
* [example_9] Switch to gz_ros2_control (#482) * Switch from gazebo classic to gazebo * update docs * Use gz_ros2_control in semi-binary builds * rm dependency conditional Co-authored-by: Dr. Denis <[email protected]> * Remove gazebo classic from repos file * Add gazebo bridge node and fix some warnings (#755) (#757) (cherry picked from commit 2587970) Co-authored-by: Julia Jia <[email protected]> --------- Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Dr. Denis <[email protected]> Co-authored-by: Christoph Froehlich <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Julia Jia <[email protected]>
The main change is to add a Gazebo bridge node to fix following Gazebo runtime error after launching the example. The error will cause Gazebo to be terminated.
The additional changes are to fix following warnings reported.
There are more warnings that appear unrelated to the example based on my initial check. I am open to change if it's not the case. For example