Skip to content

Clang warnings with pal_statistics macros #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophfroehlich opened this issue Apr 26, 2025 · 0 comments
Open

Clang warnings with pal_statistics macros #2208

christophfroehlich opened this issue Apr 26, 2025 · 0 comments
Assignees

Comments

@christophfroehlich
Copy link
Contributor

@saikishor this might be an upstream issue?

https://github.com/ros-controls/ros2_control/actions/runs/14684315684/job/41212136334?pr=2205

   /home/runner/work/ros2_control/ros2_control/.work/target_ws/src/ros2_control/hardware_interface/include/hardware_interface/handle.hpp:466:7: warning: must specify at least one argument for '...' parameter of variadic macro [-Wgnu-zero-variadic-macro-arguments]
    466 |       DEFAULT_UNREGISTER_ROS2_CONTROL_INTROSPECTION("command_interface." + get_name());
        |       ^
  /home/runner/work/ros2_control/ros2_control/.work/target_ws/src/ros2_control/hardware_interface/include/hardware_interface/introspection.hpp:51:3: note: expanded from macro 'DEFAULT_UNREGISTER_ROS2_CONTROL_INTROSPECTION'
     51 |   UNREGISTER_ENTITY(DEFAULT_REGISTRY_KEY, ID);
        |   ^
  /opt/ros/rolling/include/pal_statistics/pal_statistics/pal_statistics_macros.hpp:244:32: note: expanded from macro 'UNREGISTER_ENTITY'
    244 | #define UNREGISTER_ENTITY(...) UNREGISTER_ENTITY_MACRO_CHOOSER(__VA_ARGS__)(__VA_ARGS__)
        |                                ^
  /opt/ros/rolling/include/pal_statistics/pal_statistics/pal_statistics_macros.hpp:242:29: note: expanded from macro 'UNREGISTER_ENTITY_MACRO_CHOOSER'
    242 |     UNREGISTER_ENTITY_2_ARGS)
        |                             ^
  /opt/ros/rolling/include/pal_statistics/pal_statistics/pal_statistics_macros.hpp:154:9: note: macro 'GET_4TH_ARG' defined here
    154 | #define GET_4TH_ARG(arg1, arg2, arg3, arg4, ...) arg4
        |         ^
  In file included from /home/runner/work/ros2_control/ros2_control/.work/target_ws/src/ros2_control/hardware_interface/test/test_hardware_components/test_imu_sensor.cpp:24:
  In file included from /home/runner/work/ros2_control/ros2_control/.work/target_ws/src/ros2_control/hardware_interface/include/hardware_interface/sensor_interface.hpp:26:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants