Skip to content

FIX: param_id bug #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

FIX: param_id bug #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: tidyhydat
Title: Extract and Tidy Canadian 'Hydrometric' Data
Version: 0.7.1
Version: 0.7.1.9000
Authors@R: c(person("Sam", "Albers", email = "[email protected]", role = c("aut", "cre"),
comment = c(ORCID = "0000-0002-9270-7884")),
person("David", "Hutchinson", email = "[email protected]", role = "ctb"),
Expand Down
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# tidyhydat 0.7.1.9000
- fixed a bug where `param_id` internal data wasnt' being accessed correctly (#224)

# tidyhydat 0.7.1
- add columns added by a webservice update (#213)
- fix some partial matching in `realtime_add_local_datetime` internals
Expand Down
4 changes: 2 additions & 2 deletions R/realtime-webservice.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,14 @@ realtime_ws <- function(
) {
if (is.null(parameters)) parameters <- c(46, 16, 52, 47, 8, 5, 41, 18)

if (any(!parameters %in% param_id$Parameter)) {
if (any(!parameters %in% tidyhydat::param_id$Parameter)) {
stop(
paste0(
paste0(
parameters[!parameters %in% tidyhydat::param_id$Parameter],
collapse = ","
),
" are invalid parameters. Check param_id for a list of valid options."
" are invalid parameters. Check tidyhydat::param_id for a list of valid options."
),
call. = FALSE
)
Expand Down