Skip to content

Attempt to add a favicon #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Attempt to add a favicon #136

merged 2 commits into from
Mar 25, 2019

Conversation

wlandau
Copy link
Member

@wlandau wlandau commented Mar 25, 2019

Re ropensci/drake#783 (comment), this PR attempts to add a favicon to the dev guide. Here, I adapt the steps that worked for drake's manual:

@wlandau
Copy link
Member Author

wlandau commented Mar 25, 2019

Oh, and I forgot to add a third step: declare the favicon in the index.Rmd front matter (ref: fb03256). Now the favicon shows up when I build the dev guide on my local machine.

@maelle
Copy link
Member

maelle commented Mar 25, 2019

Thank you!!

@maelle maelle changed the base branch from master to dev March 25, 2019 08:31
@maelle maelle changed the base branch from dev to master March 25, 2019 08:32
@maelle maelle merged commit 2779881 into ropensci:master Mar 25, 2019
@maelle maelle mentioned this pull request Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants