Skip to content

fix: restore docs.scss to resolve docs links overlapping #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024

Conversation

mmaoyu
Copy link
Member

@mmaoyu mmaoyu commented May 13, 2024

Restore docs.scss to resolve version less than v1.9 docs links overlapping. The docs.scss was deleted in commit ae7e444

@mmaoyu
Copy link
Member Author

mmaoyu commented May 13, 2024

Local test result:
image
image

css/docs.scss Outdated
color: #2196f3;
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave a extra line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -0,0 +1,432 @@
---
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you show the output of broken page that was in the issue

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've updated the issue comment

@travisn
Copy link
Member

travisn commented May 13, 2024

@mmaoyu Does this simply restore the css deleted in #156? Or are there any changes?

@travisn
Copy link
Member

travisn commented May 13, 2024

@mmaoyu Does this simply restore the css deleted in #156? Or are there any changes?

The diff from previous css looks empty, i'll go ahead and merge, thanks!

@travisn travisn merged commit 0e0caf5 into rook:master May 13, 2024
2 checks passed
@mmaoyu mmaoyu deleted the links-overlap branch May 14, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants