Skip to content

fix: resolve concurrent map writes for audit cache #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 7, 2025
Merged

fix: resolve concurrent map writes for audit cache #419

merged 6 commits into from
Jan 7, 2025

Conversation

davidebianchi
Copy link
Member

@davidebianchi davidebianchi commented Dec 23, 2024 •
edited
Loading

Resolves #418

@davidebianchi davidebianchi linked an issue Dec 23, 2024 that may be closed by this pull request
audit function fails for concurrent map writes #418
Closed
@davidebianchi davidebianchi changed the title test: add test to catch concurrency issue with log audit resolve concurrent map writes for audit cache Dec 23, 2024
@davidebianchi
Copy link
Member Author

We could also enable the bench test to run with audit enabled, or to add a test case with the audit enabled. But the test on the sdk are useful (I also find the issue in the test logger in this way 😄)

@coveralls
Copy link

coveralls commented Dec 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12520017925

Details

  • 52 of 52 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 86.097%
Totals Coverage Status
Change from base Build 12294420947: 0.2%
Covered Lines: 2638
Relevant Lines: 3064
💛 - Coveralls

@davidebianchi davidebianchi marked this pull request as ready for review December 23, 2024 20:11
@davidebianchi davidebianchi added the bug Something isn't working label Dec 23, 2024
fredmaggiowski
fredmaggiowski requested changes Dec 27, 2024
View reviewed changes
@fredmaggiowski fredmaggiowski changed the title resolve concurrent map writes for audit cache fix: resolve concurrent map writes for audit cache Jan 7, 2025
fredmaggiowski
fredmaggiowski approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredmaggiowski fredmaggiowski merged commit 55ed074 into main Jan 7, 2025
10 checks passed
@fredmaggiowski fredmaggiowski deleted the fix/concurrent-audit-cache-write branch January 7, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredmaggiowski fredmaggiowski fredmaggiowski approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

audit function fails for concurrent map writes
3 participants
@davidebianchi @coveralls @fredmaggiowski