added missing whitespace to named_field #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not 100% sure but i think named_field should allow whitespace after the colon and before the value
|
That is correct - and it seems we might be missing even more |
juntyr
reviewed
Apr 26, 2022
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
=======================================
Coverage 89.65% 89.65%
=======================================
Files 48 48
Lines 5228 5228
=======================================
Hits 4687 4687
Misses 541 541 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not 100% sure but i think named_field should allow whitespace after the colon and before the value in the EBNF