Use indexmap to preserve order (optional) #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
reviewed
Jun 6, 2019
| #[cfg(not(feature = "indexmap"))] | ||
| type MapInner = std::collections::BTreeMap<Value, Value>; | ||
| #[cfg(feature = "indexmap")] | ||
| type MapInner = indexmap::IndexMap<Value, Value>; |
There was a problem hiding this comment.
what happens if we just typedef type Map = indexmap::IndexMap<..> instead of wrapping it?
There was a problem hiding this comment.
We'll end up with a non-additive feature. BTreeMap and IndexMap have different properties (traits, methods, etc.).
Also, APIs accepting BTreeMap would break once indexmap is enabled.
Exactly. If one wants to preserve the order elsewhere, they should use |
kvark
approved these changes
Jun 7, 2019
|
Thanks for the review! |
bors bot
added a commit
that referenced
this pull request
Jun 10, 2019
172: Use indexmap to preserve order (optional) r=torkleyy a=torkleyy Introduces an optional `indexmap` feature which uses `IndexMap` in `Value::Map` to preserve the order of deserialized elements. Fixes #129 Co-authored-by: Thomas Schaller <[email protected]>
Build succeeded |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces an optional
indexmapfeature which usesIndexMapinValue::Mapto preserve the order of deserialized elements.Fixes #129