Skip to content
This repository was archived by the owner on Aug 4, 2021. It is now read-only.

Add support for special characters in values #9

Merged
merged 1 commit into from
Sep 5, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ function escape ( str ) {
export default function replace ( options = {} ) {
const values = options.values || options;
const delimiters = ( options.delimiters || [ '', '' ] ).map( escape );
const pattern = new RegExp( delimiters[0] + '(' + Object.keys( values ).join( '|' ) + ')' + delimiters[1], 'g' );
const pattern = new RegExp( delimiters[0] + '(' + Object.keys( values ).map( escape ).join( '|' ) + ')' + delimiters[1], 'g' );

const filter = createFilter( options.include, options.exclude );

Expand Down
16 changes: 16 additions & 0 deletions test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,21 @@ describe( 'rollup-plugin-replace', function () {
});
});

it( 'supports special characters' , function () {
return rollup.rollup({
entry: 'samples/basic/main.js',
plugins: [
replace({
"require( 'one' )": "1"
})
]
}).then( function ( bundle ) {
const generated = bundle.generate();
const code = generated.code;

assert.ok( code.indexOf( "const one = 1" ) !== -1 );
});
});

// TODO tests for delimiters, sourcemaps, etc
});
4 changes: 4 additions & 0 deletions test/samples/basic/main.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
const one = require( 'one' );

if ( ENV !== 'production' ) {
console.log( 'running in debug mode...' );
} else {
console.log( 'running...' );
}

console.log( 'dependency:', one );