This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Match most specific (longest) variables first #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes problems that arise when a variable name is a substring of another variable, eg. BUILD and BUILD_VERSION.
|
@Rich-Harris, friendly ping. Just got reminded of this in a new project. |
|
Released 1.2.1. Thanks (and apols) again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes problems that arise when a variable name is a substring of another variable, eg.
BUILDandBUILD_VERSION.The order they are defined in the options (although ultimately decided by
Object.keys()) ends up affecting the build, as the regex pattern generated is an alternation of all the variable names.A naive solution (as used in this PR) is to simply sort the variables when creating the regex:
BUILD_VERSIONnow takes precedence overBUILDregardless of their position in the options object.NB: Sorry for closing the previous PR. I had accidentally reused the
masterbranch.