rbx_binary: Reuse Descriptors #542
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ustr only needs to be constructed in the cold path.
write in decode_inst_chunk, read in decode_prop_chunk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the construction logic for
PropertyDescriptorsinto a constructor from a knownClassDescriptorandPropertyDescriptor, and then reuses as many descriptor references as possible to avoid repeated class & property database lookups. I was also hoping for a small performance win here but it seems modest to negligable. I believe it will be easiest to review the first commit moving a block of code 8de96a4 by itself, and then the rest which are taking advantage of the isolated construction logic together krakow10/rbx-dom@8de96a4...pr4.