Use Btree Map Entry To Avoid Duplicated Work #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem to improve performance at all on my system, but I also had to make patches to it to make it actually run. Is this the code you're testing? |
|
Ah, I built the two pairs of commits separately, but never together. The first commit showed the higher throughput, but the second two didn't seem to have an impact. I ran another benchmark for this and got the weird 70% result so I posted it to #529 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is easier to read than the formatting one. This is better because
btree_map::Entrystores an open "Bucket" so the .insert operation does not have to search for an open entry again. Potentially gains 10% on "100 100-line ModuleScripts/Serialize" benchmark (unreliable?) but not much else changes.