Skip to content

Add int/float widening support to rbx_xml #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2023

Conversation

Dekkonot
Copy link
Member

With issue #301, it's became clear we need a way to widen integers and floats from 32-bit to 64-bit since older models may have outdated types for number properties. This PR implements widening for Int32 and Float32, giving them a very simple conversion to Int64 and Float64 respectively. This should solve the linked issue in the XML format and prevent it from being a problem for floats as well.

Support in rbx_binary is straightforward but the author of that issue has a fix ready to merge, so I'll let them do it. 😄

Copy link
Member

@kennethloeffler kennethloeffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for adding the comment

@Dekkonot Dekkonot merged commit 835a7d3 into rojo-rbx:master Jul 1, 2023
@Dekkonot Dekkonot deleted the xml_number_widening branch July 1, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants