Add int/float widening support to rbx_xml #303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With issue #301, it's became clear we need a way to widen integers and floats from 32-bit to 64-bit since older models may have outdated types for number properties. This PR implements widening for
Int32
andFloat32
, giving them a very simple conversion toInt64
andFloat64
respectively. This should solve the linked issue in the XML format and prevent it from being a problem for floats as well.Support in
rbx_binary
is straightforward but the author of that issue has a fix ready to merge, so I'll let them do it. 😄