Skip to content

Correct Serialize implementation of BinaryString and upgrade database #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2023
Merged

Correct Serialize implementation of BinaryString and upgrade database #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e37c2d
Add a cleaner panic to rbx_reflection_database de failure
Dekkonot May 25, 2023
7399a0a
Correct serializer implementation for BinaryString
Dekkonot May 27, 2023
081784e
Upgrade version of `rmp-serde` used by reflection database
Dekkonot May 27, 2023
d546086
Update database to Roblox v577
Dekkonot May 27, 2023
c554c09
Update snapshots to reflect new database changes
Dekkonot May 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions rbx_binary/src/tests/snapshots/rbx_binary__tests__util__baseplate-566__decoded.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ expression: decoded_viewed
Material:
Enum: 256
MaterialVariantSerialized:
BinaryString: ""
String: ""
PivotOffset:
CFrame:
position:
Expand Down Expand Up @@ -447,7 +447,7 @@ expression: decoded_viewed
MaterialColors:
BinaryString: AAAAAAAAb34+WFlWmJiYimFJz8unrJRsY2Rm3eTl6/3/lHxfeXBiS0pKjIJo/xhDUFRUhoZ2zNLfaoZA///+//PAj5CH
MaterialVariantSerialized:
BinaryString: ""
String: ""
PhysicsGrid:
BinaryString: AgMAAAAAAAAAAAAAAAA=
PivotOffset:
Expand Down Expand Up @@ -621,7 +621,7 @@ expression: decoded_viewed
Material:
Enum: 256
MaterialVariantSerialized:
BinaryString: ""
String: ""
Neutral:
Bool: true
PivotOffset:
Expand Down
3 changes: 1 addition & 2 deletions .../src/tests/snapshots/rbx_binary__tests__util__default-inserted-modulescript__decoded.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
source: rbx_binary/src/tests/util.rs
assertion_line: 33
expression: decoded_viewed
---
- referent: referent-0
Expand All @@ -12,7 +11,7 @@ expression: decoded_viewed
LinkedSource:
Content: ""
ScriptGuid:
BinaryString: ezI3RTM5RkVCLTI3QjctNDNFQy05Mzk4LTA0MTE1Q0Y4NTZCMn0=
String: "{27E39FEB-27B7-43EC-9398-04115CF856B2}"
Source:
String: "local module = {}\n\nreturn module\n"
Tags:
Expand Down
17 changes: 8 additions & 9 deletions rbx_binary/src/tests/snapshots/rbx_binary__tests__util__sharedstring__decoded.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
source: rbx_binary/src/tests/util.rs
assertion_line: 33
expression: decoded_viewed
---
- referent: referent-0
Expand Down Expand Up @@ -159,7 +158,7 @@ expression: decoded_viewed
Material:
Enum: 272
MaterialVariantSerialized:
BinaryString: ""
String: ""
MeshData:
BinaryString: ""
MeshData2:
Expand Down Expand Up @@ -330,7 +329,7 @@ expression: decoded_viewed
Material:
Enum: 272
MaterialVariantSerialized:
BinaryString: ""
String: ""
MeshData:
BinaryString: ""
MeshData2:
Expand Down Expand Up @@ -501,7 +500,7 @@ expression: decoded_viewed
Material:
Enum: 1088
MaterialVariantSerialized:
BinaryString: ""
String: ""
MeshData:
BinaryString: ""
MeshData2:
Expand Down Expand Up @@ -672,7 +671,7 @@ expression: decoded_viewed
Material:
Enum: 272
MaterialVariantSerialized:
BinaryString: ""
String: ""
MeshData:
BinaryString: ""
MeshData2:
Expand Down Expand Up @@ -843,7 +842,7 @@ expression: decoded_viewed
Material:
Enum: 272
MaterialVariantSerialized:
BinaryString: ""
String: ""
MeshData:
BinaryString: ""
MeshData2:
Expand Down Expand Up @@ -1014,7 +1013,7 @@ expression: decoded_viewed
Material:
Enum: 272
MaterialVariantSerialized:
BinaryString: ""
String: ""
MeshData:
BinaryString: ""
MeshData2:
Expand Down Expand Up @@ -1185,7 +1184,7 @@ expression: decoded_viewed
Material:
Enum: 1088
MaterialVariantSerialized:
BinaryString: ""
String: ""
MeshData:
BinaryString: ""
MeshData2:
Expand Down Expand Up @@ -1356,7 +1355,7 @@ expression: decoded_viewed
Material:
Enum: 272
MaterialVariantSerialized:
BinaryString: ""
String: ""
MeshData:
BinaryString: ""
MeshData2:
Expand Down
Loading