Patch ScaleFactor to Scale in reflection database #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds ScaleFactor via reflection patch * Marks Scale as alias for ScaleFactor * Add custom setter and no getter for Scale Signed-off-by: Dekkonot <[email protected]>
|
I think you need to set |
stravant
reviewed
Mar 8, 2023
Signed-off-by: Dekkonot <[email protected]>
LPGhatguy
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, we do not serialize
ScaleFactor. This is mostly fine, except Roblox has begun emitting models withScaleFactorso Rojo occasionally merges them when building models. This has the result of us producing files withScaleFactorset to0, which is not good.This is not critical right now because model scaling is in beta and most people don't have it enabled. It might become critical in the future though. So, this PR patches it so we won't have that problem.
I also added
Scaleas an alias for it because that's what it's exposed to users as in Studio and it's more intuitive thanScaleFactor.This is my first time adding a patch to the database and I probably made a mistake, but I did my best. Please let me know if anything needs to change.