-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
✅ Deploy Preview for academic-folio ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
Most of the features look good except the code blocks, for that I think we have to add another color for code background. |
@pourmand1376, can you confirm if all the markdown features are working correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding all these improvements. I agree that we should add another color for code-background.
I updated the blog post to also support the extended markdown format
. You can check here for more information.
Here are some suggestions to make it better.
1- There is no clear distinction between Heading 5 and 6. Also Heading 1 is too big.
2- We should backticks when rendering inline code blocks. Also, the background-color should be different.
3- The definition list is not working properly.
4- Link Hover is not working. When we hover over a link, It should show something like this. Note the blue link icon.
5- Task list has lots of extra spaces.
6- Emojishort codes are not working.
7- We can have a copy
icon for code-blocks like here.
Thank you for taking the time to check all the markdown syntax. Also thank you for the suggestions, here are my replies:
Many of these could depend on the personal choice of the users. I suggest to add another |
Hey @pourmand1376, I went ahead and fixed the Could not do anything to Added a custom scss file for users to add their own custom styles so that there is no conflicts during updating. Sorry, I think I misunderstood the emoji short code problem. This was a configuration problem, I enabled it. |
Thanks for the changes and explanation. I respect your personal preferences. In fact, I think they are very good. Now, It looks a lot better. Just two minor recommendations: |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I have removed the backticks from inline code blocks. Also made sure the code blocks are hilighted even if no language was provided (will fallback as .txt). Since the previous hilight theme (monokai) wasn't looking good I replaced it with Dracula which can be easily configured from config. |
closes #54. This can only be merged after #53. @pourmand1376, I replaced the hamburger menu completely with a normal always visible menu (no JavaScript). I did not keep an option since in the long run it might be difficult to maintain two menus.
Added
@tailwindcss/typography
plugin to render markdown content only.