Skip to content

Search for "rocq doc" instead of "coqdoc" in coqdoc/main.py #20709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

Villetaneuse
Copy link
Contributor

The doc/tools/coqrst/coqdoc/main.py script now searches for rocq instead of coqdoc.

@Villetaneuse Villetaneuse requested a review from a team as a code owner June 4, 2025 15:42
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jun 4, 2025
@Villetaneuse
Copy link
Contributor Author

The small simplification in lex was not intended to be commited.
Tell me if we should keep it.

@SkySkimmer SkySkimmer self-assigned this Jun 5, 2025
@Villetaneuse Villetaneuse force-pushed the coqdoc.py_rocqdoc branch 2 times, most recently from 69fce46 to 2b67517 Compare June 6, 2025 13:21
@coqbot-app coqbot-app bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jun 6, 2025
Also change coqdoc and coqtop filename argument

doc/tools/coqrst/coqdoc/main.py
and
doc/tools/coqrst/repl/coqtop.py
now expect "path/to/rocq" as argument (if given).
@coqbot-app coqbot-app bot removed the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jun 6, 2025
@Villetaneuse
Copy link
Contributor Author

pfiou, some rebasing went wrong... this should now be ok

@SkySkimmer SkySkimmer added kind: cleanup Code removal, deprecation, refactorings, etc. and removed needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Jun 6, 2025
@SkySkimmer SkySkimmer added this to the 9.1+rc1 milestone Jun 6, 2025
@SkySkimmer
Copy link
Contributor

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 0db752f into rocq-prover:master Jun 10, 2025
6 checks passed
@Villetaneuse
Copy link
Contributor Author

Thank you again @SkySkimmer

@Villetaneuse Villetaneuse deleted the coqdoc.py_rocqdoc branch June 12, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: cleanup Code removal, deprecation, refactorings, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants