Add changes to align inference-exp with refrence RFDetr implementation
#1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this with local file weights (pulled via rf-detr main repo) and it worked well. Do we need additional changes or registry changes before PR review and merging? |
PawelPeczek-Roboflow
requested review from
grzegorz-roboflow,
yeldarby and
probicheaux
as code owners
hansent
reviewed
Jul 31, 2025
| implied_resolution = positional_encoding_size * patch_size | ||
|
|
||
| if implied_resolution != dino_config["image_size"]: | ||
| print( |
There was a problem hiding this comment.
we should think about how we want to do logging long term. Thinking both for general dev-ex and potentially structured logging or log files for analytics / debugging purposes.
PawelPeczek-Roboflow
deleted the
feature/rfdetr-upgrade-in-inference-exp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to RFDetr to align with reference implementation
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs