Skip to content

Survival Score issue #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
594872799 opened this issue Dec 24, 2024 · 6 comments
Closed

Survival Score issue #122

594872799 opened this issue Dec 24, 2024 · 6 comments
Assignees
@flemming-n-larsen

Comments

@594872799
Copy link

594872799 commented Dec 24, 2024 •
edited
Loading

In the scoring rules, the description states: "Each bot that survives a round scores 50 points every time another bot dies." But my debugging results don’t match this. For example, how could two tanks in two rounds have a survival score of 150?

image

https://robocode-dev.github.io/tank-royale/articles/scoring.html
@594872799
Copy link
Author

@flemming-n-larsen Please help me take a look.

@594872799
Copy link
Author

It seems like this will multiply by the number of rounds.

@flemming-n-larsen flemming-n-larsen added the potential bug Something might not be working label Dec 27, 2024
@flemming-n-larsen
Copy link
Contributor

@594872799
Sorry, for the late reply. It is Christmas in Denmark.

I will have a look into this. 🙂

@flemming-n-larsen flemming-n-larsen added bug and removed potential bug Something might not be working labels Dec 27, 2024
@flemming-n-larsen
Copy link
Contributor

@594872799
You are right. After two rounds, the Survival Score should be 2 x 50 = 100, and the Last Survival Bonus should be 2 x 10 = 20

I will fix this.

@594872799

This comment was marked as resolved.

Sign in to view
@flemming-n-larsen flemming-n-larsen changed the title scoring question Survival Score issue Dec 27, 2024
flemming-n-larsen added a commit that referenced this issue Dec 27, 2024
@flemming-n-larsen
#122: Fixed scoring issue with Survival Score and Last Survivor Bonus…
c8d4d5a 
…, which was got to big after multiple rounds.
flemming-n-larsen added a commit that referenced this issue Dec 31, 2024
@flemming-n-larsen
#122: Fixed more issues with the Survival Score and Last Survivor Bon…
98dccbf 
…us due to as the ScoreAndDamage needed to be reset after each round.
@flemming-n-larsen
Copy link
Contributor

This bug has been fixed with release 0.28.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flemming-n-larsen flemming-n-larsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flemming-n-larsen @594872799